Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clean up AGENT_TOOLSDIRECTORY #7830

Merged
merged 2 commits into from Feb 15, 2023

Conversation

harupy
Copy link
Member

@harupy harupy commented Feb 14, 2023

Signed-off-by: harupy 17039389+harupy@users.noreply.github.com

Related Issues/PRs

actions/runner-images#709

What changes are proposed in this pull request?

We used to have a much smaller disk space (~10GB) so rm -rf "$AGENT_TOOLSDIRECTORY" was needed to free up some disk space. However, we have a larger disk space (~30GB) now so we don't need to run rm -rf "$AGENT_TOOLSDIRECTORY" anymore.

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Feb 14, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Feb 14, 2023

Documentation preview for 3fb2b04 will be available here when this CircleCI job completes successfully.

More info

@harupy
Copy link
Member Author

harupy commented Feb 14, 2023

Removing /opt/hostedtoolcache frees up about 9GB disk space:

+ df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   51G   33G  61% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sdb15      105M  5.3M  100M   5% /boot/efi
/dev/sda1        14G  4.1G  9.0G  31% /mnt
tmpfs           695M   [12](https://github.com/mlflow/mlflow/actions/runs/4169937735/jobs/7218418083#step:3:13)K  695M   1% /run/user/1001
+ rm -rf /opt/hostedtoolcache

+ df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   42G   42G  51% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sdb15      105M  5.3M  100M   5% /boot/efi
/dev/sda1        [14](https://github.com/mlflow/mlflow/actions/runs/4169937735/jobs/7218418083#step:3:15)G  4.1G  9.0G  31% /mnt
tmpfs           695M   12K  695M   1% /run/user/1001

We have 33GB disk space by default. I thin that should be enough.

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@harupy harupy changed the title Check AGENT_TOOLSDIRECTORY Do not clean up AGENT_TOOLSDIRECTORY Feb 14, 2023
@harupy harupy changed the title Do not clean up AGENT_TOOLSDIRECTORY Do not clean up AGENT_TOOLSDIRECTORY Feb 14, 2023
@harupy harupy merged commit 29b45df into mlflow:master Feb 15, 2023
@harupy harupy deleted the check-AGENT_TOOLSDIRECTORY branch February 15, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants