Improve error messages dealing with deleted experiments #814
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mparkhe
reviewed
Jan 16, 2019
mlflow/store/file_store.py
Outdated
| raise MlflowException( | ||
| "Experiment '%s' already exists in deleted state. " | ||
| "You can restore the experiment, or permanently delete the experiment " | ||
| "from the .trash folder to create a new one." % experiment.name, |
There was a problem hiding this comment.
Does it make sense to word it something like
from the .trash folder (under tracking server root folder) before
creating a new one with the same name.
|
Test error looks spurious and it passed before the nit fix, so merging. Thanks @mparkhe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular
set_experimentandcreate_experimentto return more descriptive error messages when they are called with a name for an experiment that already exists but has been deleted. Currently:set_experimentwill succeed but followingstart_runcalls will fail because the experiment is not active.create_experimentwill fail saying that there is already an experiment with the same name.With this PR:
set_experimentwill not succeed, with an error message saying there is a deleted experiment with the same name.create_experimentwill fail saying that there is already a deleted experiment with the same name.Added unit tests to cover these code paths.