Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log table to log dictionary or df as artifacts in MLflow run #8467

Merged
merged 1 commit into from
May 23, 2023

Conversation

sunishsheth2009
Copy link
Collaborator

What changes are proposed in this pull request?

Adding log table to log dictionary or df as artifacts in MLflow run

How is this patch tested?

  • Add tests
  • Notebook

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

Adding log table to log dictionary or df as artifacts in MLflow run

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
Comment on lines 1063 to 1067
if existing_predictions.shape[0] + data.shape[0] > 1000:
_logger.warning(
f"Trying to log a {LLM_ARTIFACT_NAME} with length "
"more than 1000 records. It might slow down performance."
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this warning for now. Saving thousands, even hundreds of thousands, of lines of CSV is likely fine performance wise

Copy link
Collaborator

@dbczumar dbczumar May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunishsheth2009 @hubertzub-db regardless, we'll want to think about memory usage in the browser when we load these artifacts, right? Is there an approach we can take for memory safety - e.g. paginating artifact downloads?

If an artifact is too large, we may want to skip it and show a warning with a list of run IDs for which table data could not be rendered

@mlflow-automation
Copy link
Collaborator

mlflow-automation commented May 19, 2023

Documentation preview for 3fdac6f will be available here when this CircleCI job completes successfully.

More info

@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. labels May 19, 2023
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
mlflow/tracking/fluent.py Outdated Show resolved Hide resolved
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-log-table branch 9 times, most recently from 6e291bb to 1be8311 Compare May 19, 2023 23:00
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-log-table branch 3 times, most recently from 8cf5444 to 7685347 Compare May 22, 2023 22:11
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once the remaning comments are addressed!

mlflow/tracking/client.py Outdated Show resolved Hide resolved
@harupy harupy marked this pull request as ready for review May 23, 2023 00:10
mlflow/tracking/client.py Outdated Show resolved Hide resolved
mlflow/tracking/client.py Outdated Show resolved Hide resolved
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-add-log-table branch 5 times, most recently from d8320e6 to 51c20a6 Compare May 23, 2023 04:57
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
@sunishsheth2009 sunishsheth2009 merged commit 3750525 into master May 23, 2023
26 checks passed
@sunishsheth2009 sunishsheth2009 deleted the sunish-add-log-table branch May 23, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants