-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding log table to log dictionary or df as artifacts in MLflow run #8467
Conversation
8b478f6
to
add79e5
Compare
mlflow/tracking/fluent.py
Outdated
if existing_predictions.shape[0] + data.shape[0] > 1000: | ||
_logger.warning( | ||
f"Trying to log a {LLM_ARTIFACT_NAME} with length " | ||
"more than 1000 records. It might slow down performance." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this warning for now. Saving thousands, even hundreds of thousands, of lines of CSV is likely fine performance wise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunishsheth2009 @hubertzub-db regardless, we'll want to think about memory usage in the browser when we load these artifacts, right? Is there an approach we can take for memory safety - e.g. paginating artifact downloads?
If an artifact is too large, we may want to skip it and show a warning with a list of run IDs for which table data could not be rendered
Documentation preview for 3fdac6f will be available here when this CircleCI job completes successfully. More info
|
6e291bb
to
1be8311
Compare
8cf5444
to
7685347
Compare
7685347
to
306b2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me once the remaning comments are addressed!
306b2f2
to
7acf71d
Compare
d8320e6
to
51c20a6
Compare
Signed-off-by: Sunish Sheth <sunishsheth2009@gmail.com>
51c20a6
to
3fdac6f
Compare
What changes are proposed in this pull request?
Adding log table to log dictionary or df as artifacts in MLflow run
How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
Adding log table to log dictionary or df as artifacts in MLflow run
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts
: Artifact stores and artifact loggingarea/build
: Build and test infrastructure for MLflowarea/docs
: MLflow documentation pagesarea/examples
: Example codearea/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models
: MLmodel format, model serialization/deserialization, flavorsarea/recipes
: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects
: MLproject format, project running backendsarea/scoring
: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra
: MLflow Tracking server backendarea/tracking
: Tracking Service, tracking client APIs, autologgingInterface
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows
: Windows supportLanguage
language/r
: R APIs and clientslanguage/java
: Java APIs and clientslanguage/new
: Proposals for new client languagesIntegrations
integrations/azure
: Azure and Azure ML integrationsintegrations/sagemaker
: SageMaker integrationsintegrations/databricks
: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" sectionrn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature
- A new user-facing feature worth mentioning in the release notesrn/bug-fix
- A user-facing bug fix worth mentioning in the release notesrn/documentation
- A user-facing documentation change worth mentioning in the release notes