Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing basic_auth.ini in PyPI package #8499

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

gabrielfu
Copy link
Collaborator

@gabrielfu gabrielfu commented May 23, 2023

Signed-off-by: Gabriel Fu hfu.gabriel@gmail.com

Related Issues/PRs

resolves #8497

What changes are proposed in this pull request?

Added basic_auth.ini in setup.py

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Tested locally with python setup.py sdist :

copying mlflow\server\auth\__init__.py -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\basic_auth.ini -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\config.py -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\entities.py -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\logo.py -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\permissions.py -> mlflow-2.3.3.dev0\mlflow\server\auth
copying mlflow\server\auth\sqlalchemy_store.py -> mlflow-2.3.3.dev0\mlflow\server\auth

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Gabriel Fu <hfu.gabriel@gmail.com>
@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/bug-fix Mention under Bug Fixes in Changelogs. labels May 23, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented May 23, 2023

Documentation preview for bcb3bd8 will be available here when this CircleCI job completes successfully.

More info

Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

setup.py Outdated
@@ -39,6 +39,7 @@ def remove_comments_and_empty_lines(lines):
extra_files = [
"pypi_package_index.json",
"pyspark/ml/log_model_allowlist.txt",
"../mlflow/server/auth/basic_auth.ini",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need ../mlflow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, but I saw that's the format being used in alembic_files a few lines above

Copy link
Member

@harupy harupy May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Let's remove it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #8504

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! i've removed mine too

Signed-off-by: Gabriel Fu <hfu.gabriel@gmail.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy enabled auto-merge (squash) May 23, 2023 10:04
@harupy harupy merged commit b353e3b into mlflow:master May 23, 2023
26 checks passed
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request May 23, 2023
* add missing file in setup.py
Signed-off-by: Gabriel Fu <hfu.gabriel@gmail.com>

* remove relative path
Signed-off-by: Gabriel Fu <hfu.gabriel@gmail.com>
@gabrielfu gabrielfu deleted the fix/pypi branch June 29, 2023 02:45
@harupy harupy added the auth label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracking Tracking service, tracking client APIs, autologging auth rn/bug-fix Mention under Bug Fixes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing basic_auth.ini in PyPI package
4 participants