Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload openai after setting OPENAI_API_KEY #8520

Merged
merged 2 commits into from
May 24, 2023
Merged

Conversation

harupy
Copy link
Member

@harupy harupy commented May 24, 2023

Related Issues/PRs

#8514

What changes are proposed in this pull request?

Reload openai after setting OPENAI_API_KEY.

# openai/__init__.py looks like this:

...
    Moderation,
)
from openai.error import APIError, InvalidRequestError, OpenAIError

if TYPE_CHECKING:
    from aiohttp import ClientSession

api_key = os.environ.get("OPENAI_API_KEY")
# this is set when openai is imported
# just updating os.environ doesn't update api_key

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy requested a review from liangz1 May 24, 2023 11:38
@harupy
Copy link
Member Author

harupy commented May 24, 2023

@liangz1 Feel free to merge if all the CI checks are green :)

@harupy
Copy link
Member Author

harupy commented May 24, 2023

Why has #8514 been merged? I enabled auto-merge. Cross-version tests are optional checks (we can't mark them as required because they run optionally when relevant files are changed). So it was merged.

@harupy harupy added enable-dev-tests Enables cross-version tests for dev versions only-latest If applied, only test the latest version of each group in cross-version tests. labels May 24, 2023
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label May 24, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented May 24, 2023

Documentation preview for e4f0d9d will be available here when this CircleCI job completes successfully.

More info

Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy merged commit ec153de into mlflow:master May 24, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-dev-tests Enables cross-version tests for dev versions only-latest If applied, only test the latest version of each group in cross-version tests. rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants