Replace tmpdir with tmp_path
#8603
Conversation
Signed-off-by: harupy <hkawamura0130@gmail.com>
harupy
added
the
only-latest
|
Documentation preview for 05acc13 will be available here when this CircleCI job completes successfully. More info
|
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
Signed-off-by: harupy <hkawamura0130@gmail.com>
| def model_path(tmpdir): | ||
| return tmpdir.join("model").strpath | ||
| def model_path(tmp_path): | ||
| return os.path.join(tmp_path, "model") |
There was a problem hiding this comment.
This isn't ideal, but using a Path object might break tests.
| @@ -238,10 +238,10 @@ def mlflow_autolog(): | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures(test_mode_off.__name__) | |||
| def test_autolog_respects_silent_mode(tmpdir): | |||
| def test_autolog_respects_silent_mode(tmp_path): | |||
There was a problem hiding this comment.
There are more tmpdir. This PR just fixed easy-to-replace ones.
| db_file = tmp_path.joinpath("db_file") | ||
| return f"sqlite:///{db_file}" |
There was a problem hiding this comment.
| db_file = tmp_path.joinpath("db_file") | |
| return f"sqlite:///{db_file}" | |
| return "sqlite:///" + tmp_path.joinpath("db_file") |
There was a problem hiding this comment.
str and Path can't be joined.
>>> from pathlib import Path
>>> "a" + Path("a")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: can only concatenate str (not "PosixPath") to strThere was a problem hiding this comment.
Ahhh right, what about using single quote f'sqlite:///{tmp_path.joinpath("db_file")}'?
There was a problem hiding this comment.
Can file a follow-up if necessary
| @@ -217,7 +217,7 @@ def test_run(use_start_run): | |||
| assert tags[MLFLOW_PROJECT_ENTRY_POINT] == "test_tracking" | |||
|
|
|||
|
|
|||
| def test_run_with_parent(tmpdir): # pylint: disable=unused-argument | |||
| def test_run_with_parent(): | |||
There was a problem hiding this comment.
Why did we need it previously?
There was a problem hiding this comment.
I have zero idea :) If tmpdir is needed, this test should've failed, but it didn't.
Related Issues/PRs
#xxxWhat changes are proposed in this pull request?
Replace
tmpdirfixture (lebacy) withtmp_pathfixture (preferred).How is this patch tested?
Does this PR change the documentation?
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templatesarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes