Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout of python job #8620

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

harupy
Copy link
Member

@harupy harupy commented Jun 6, 2023

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Increase the timeout of the python job. On master, we see several timed-out jobs:

How is this patch tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests (describe details, including test results, below)

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly in the documentation preview.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@harupy harupy changed the title Increase timetout of python job Increase timeout of python job Jun 6, 2023
Signed-off-by: harupy <hkawamura0130@gmail.com>
@serena-ruan
Copy link
Collaborator

Instead of increasing the timeout time, could we split the job to run against different folders tests in parallel?

@harupy
Copy link
Member Author

harupy commented Jun 6, 2023

Instead of increasing the timeout time, could we split the job to run against different folders tests in parallel?

We could if we had more github action runners. We currently only have 20 (free plan). Splitting a job is not free because we must install dependencies to run tests. If we have one job, we can install them once, but if we have two, we need to install them twice. This diff can be amplified by the number of developers we have.

Copy link
Collaborator

@serena-ruan serena-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harupy harupy merged commit b380d94 into mlflow:master Jun 6, 2023
2 checks passed
@harupy harupy deleted the increase-timeout branch June 6, 2023 04:05
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Jun 6, 2023
@mlflow-automation
Copy link
Collaborator

mlflow-automation commented Jun 6, 2023

Failed to find a documentation preview for 80bd562.

More info

@PenHsuanWang PenHsuanWang mentioned this pull request Jun 6, 2023
33 tasks
BenWilson2 pushed a commit to BenWilson2/mlflow that referenced this pull request Jun 9, 2023
Signed-off-by: harupy <hkawamura0130@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants