Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BN issue due to torch version #8 #49

Merged
merged 3 commits into from Jan 16, 2022
Merged

fix BN issue due to torch version #8 #49

merged 3 commits into from Jan 16, 2022

Conversation

DeH40
Copy link
Contributor

@DeH40 DeH40 commented Jan 14, 2022

No description provided.

@mli0603 mli0603 linked an issue Jan 15, 2022 that may be closed by this pull request
Torch version affects the network's training performance #8
Closed
@mli0603 mli0603 self-assigned this Jan 15, 2022
@mli0603 mli0603 self-requested a review January 15, 2022 19:50
@mli0603
Copy link
Owner

mli0603 commented Jan 15, 2022 •
edited

@DeH40

Thanks for the PR! I have verified this works on my end. However, this will introduce problems with model loading because now it expects running_var and running_mean in the state dict. I can fix this on your PR if you want.

Do you mind giving me permission to change this PR? The instruction is here:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thanks again!

@DeH40
Copy link
Contributor Author

DeH40 commented Jan 16, 2022

Sure，you can fix the loading problem on my PR 😄 .

@mli0603 mli0603 changed the title fix the bug mentioned in Issue #8 fix BN issue due to torch version #8 Jan 16, 2022
@mli0603 mli0603 merged commit 6054799 into mli0603:main Jan 16, 2022
@mli0603 mli0603 mentioned this pull request Mar 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mli0603 mli0603 Awaiting requested review from mli0603

Assignees

@mli0603 mli0603

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Torch version affects the network's training performance
2 participants
@DeH40 @mli0603