Fix websocket client to close when outgoing sink completes #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WebSocketClient
fails to close the socket when the outgoing sink completes. This means that the remote server never sees the stream complete.This PR moves the outgoing logic to
WebSocketSubscriber
which can close the socket when the stream completes. TheWebSocketSubscriber
also correctly closes the socket on an exception with the appropriate error code and exception message.