New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websocket client to properly start and stop akka stream #18

Merged

mliarakos merged 1 commit into develop from fix/websocket-stream

May 27, 2020

Owner

mliarakos commented May 27, 2020

The WebSocketClient does not properly start and stop it's Akka stream:

if the socket closes the client outgoing stream is not cancelled
the client incoming stream starts immediately, rather than waiting for the initial Subscription request

This PR fixes both those issues.


          fixed websocket client to properly start and stop akka stream

339571e

mliarakos merged commit a44441a into develop

mliarakos deleted the fix/websocket-stream branch

May 27, 2020 23:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment