Horizontal Navigation #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created the From Other Institutions (Interlibrary Loan) page - Added redirects for Requests pages - Added testing for new and updated pages - Updated `shelf_navigation` to be `horizontal_navigation`, making it more global since it's used in both Shelf and Requests
- Added the view to all /shelf/ and /requests/ pages. - Deleted shelf_navigation and requests_navigation.
erinesullivan
added
enhancement
niquerio
reviewed
Feb 16, 2021
jonearley
reviewed
Feb 19, 2021
jonearley
approved these changes
Feb 19, 2021
| @@ -0,0 +1,20 @@ | |||
| <% | |||
| path = request.path_info | |||
| nav = HorizontalNav.for(path) | |||
There was a problem hiding this comment.
I love this change! This makes it easy for the horizontal nav to be reused because of your careful reorganizations of concerns and related logic.
Fantastic work, Erin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As a part of getting ILLiad up and running on the site, the
From Other Institutions (Interlibrary Loan)page needed to be added underRequests. This required horizontal navigation to be added (similar to what you see inShelf), redirects to be made, and unit tests to be updated.Horizontal Navigation
In an effort to keep programming DRY, I created the
horizontal_navview and model to help generate the secondary navigations for all pages that are underShelfandRequests. Any changes that need to be made in that area can be done within that file.Testing
docker-compose run web bundle exec rspecto make sure the tests pass. Try and break the tests to double-check.npm run compileto make sure the styles compile successfully.http://localhost:4567/requests/um-library.ShelfandRequestspages to make sure nothing is broken.