-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong license - must be GPL due to GPL dependency #271
Comments
Thank you for bringing that to my attention, you are right. The only point here is, that not all of the forks are based on the current version, a lot of them are pretty old, and use the old version, that had chessboardjs inside. That is true as well for https://github.com/xeyownt/mwpgnjs, I checked their test web site and the sources, and found no reference to chessground. I will fix that license soon, and do whatever I can do to ensure that this is followed on dependent projects. The relevant timepoint / tag is https://github.com/mliebelt/PgnViewerJS/releases/tag/v.0.9.7 that means
|
Thank you! |
Forgot to update the top |
I see you licensed the At the moment the root project that contains both I think It's not a problem for a GPL project (root) to contain Apache licensed code ( |
Thank you for your comment. I am not sure about that either. For me, the repository as a whole contains the history, but I publish the packages through NPM. There, I have pgn-reader and pgn-viewer with the correct licenses. Of course, anyone can clone/fork the repository, but the README makes it clear that the viewer is licensed as GPL. But I can add the license again (GPL) to the repository, because the usage by all will be to use the viewer, not the reader. |
Thanks. I think it's the correct decision. A repository containing GPL code has to be licensed as GPL. |
This project, or at least the pgn-viewer module, must be released under the GPL license.
The reason is that it uses chessground which is licensed as GPL-3.0.
According to the terms of the license, any work depending on chessground must be released itself as GPL-3.0.
By extension, all programs or libraries depending on PgnViewerJS must also be released as GPL.
This includes:
The text was updated successfully, but these errors were encountered: