-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement all of commentary #97
Comments
Currently, the parser works with a normalized PGN string, that does not contain any newline characters. Therefore, the end-of-line comment cannot work in that representation. The following should be possible:
This should be possible. |
Added wiki page to have more place to think about a possible implementation (without having too much to change ...) |
The input is now more tolerant, newlines and other whitespace is allowed nearly everywhere. I had no problems in parsing the whole TWIC (> 9.000 games) without an error. So perhaps those kind of comments are not relevant any more? |
The new version 1.2.0 of pgn-parser has fixed all of this. Issue is closed therefore. |
Take the section http://www.saremba.de/chessgml/standards/pgn/pgn-complete.htm#c5 seriously. This means the following:
This will avoid hassles when importing games annotated by others. E.g. studies in lichess.org have comments by some commenters, and the will just line up.
The text was updated successfully, but these errors were encountered: