[RFC] Feature #26 export to ical #27

NMFR · 2019-01-09T15:42:33Z

No description provided.

golog.go

ical_exporter.go

ical_exporter_test.go

jsaguiar

/Users/joao/Desktop/golog/golog.go:15: exported const ExportICal should have comment (or a comment on this block) or be unexported
/Users/joao/Desktop/golog/golog.go:18: exported var ExporterNames should have comment or be unexported
/Users/joao/Desktop/golog/ical_exporter.go:5: exported const PRODID should have comment or be unexported
/Users/joao/Desktop/golog/ical_exporter.go:7: exported type ICalTaskExporter should have comment or be unexported
/Users/joao/Desktop/golog/ical_exporter.go:83: exported method ICalTaskExporter.Export should have comment or be unexported
/Users/joao/Desktop/golog/ical_exporter.go:121: exported method ICalTaskExporter.GetFileExtension should have comment or be unexported
/Users/joao/Desktop/golog/tasks.go:4: exported const TaskStart should have comment (or a comment on this block) or be unexported

golog.go

ical_exporter.go

golog.go

ical_exporter.go

golog.go

ical_exporter.go

To export run: ```sh golog export ``` Or: ```sh golog export ical golog.ics ``` Closes mlimaloureiro#26

Version 1.1.2 is being removed due to and error on the github.com/codegangsta/cli@v1.20.0 dependency: ```` ../../codegangsta/cli/context.go:170: undefined: flag.Getter ``` Seems codegangsta/cli is using go's flag.Getter that was only [added in go v1.2](golang/go@49b3301) Other versions were replaced by 1.11.4 because the project started using go modules

Add SetTask and SetTasks methods to TaskRepositoryInterface Implement the new TaskRepositoryInterface methods Add csv export format to the CLI Add comments to public structs / methods

Closes mlimaloureiro#7

models/tasks/activity_test.go

mlimaloureiro · 2019-01-22T10:08:03Z

models/tasks/activity_test.go

+
+		t.Run("not running", func(t *testing.T) {
+			taskActivity := TaskActivity{StartDate: timeFromString("2019-01-01T10:00:01Z"), EndDate: timeFromString("2019-01-02T10:00:00Z")}
+			assert.Equal(t, 24*time.Hour-1*time.Second, taskActivity.Duration())


add space between operators for readability:

24 * time.Hour - 1 * ...

go fmt removes the spaces there.

mlimaloureiro · 2019-01-22T10:12:38Z

models/tasks/activity.go

+// TaskActivity represents a date interval of a task execution
+type TaskActivity struct {
+	StartDate time.Time
+	EndDate   time.Time // EndDate.IsZero() indicates a running task, meaning the 0001-01-01 EndDate cannot be represented


should we have in line comments, or comments in the previous line ? let's also add this to the standards if we don't have it

If we have to pick only one i would vote for comments in the previous line. Helps keeping line length low and provides a explanation / comment before the actual code

But do we really need to pick only one? Sometimes i think it makes sense inline, like in this occurrence where it seems to make more sense to have the comment explaining the meaning of EndDate.IsZero() after EndDate has been declared.

models/tasks/activity_test.go

mlimaloureiro · 2019-01-22T10:22:44Z

repositories/tasks/deleter_repository.go

+package tasks // import github.com/mlimaloureiro/golog/repositories/tasks
+
+// DeleterTaskRepositoryInterface is a TaskRepositoryInterface that can also delete tasks directly
+type DeleterTaskRepositoryInterface interface {


what was the reason to have a dedicated interface?

Some repositories might have implementations for this 2 operations (for example a SQL repository). This interface would allow TaskService to call those methods directly instead of using GetTasks() -> SetTasks() to delete tasks. Something similar to StarterPauserTaskRepositoryInterface.

But currently no repositories implement it.

Should i remove it?

repositories/tasks/file/csv/repository_test.go

mlimaloureiro · 2019-01-22T10:26:59Z

repositories/tasks/file/csv/repository_test.go

+func getFileContent(t *testing.T, filePath string) string {
+	stringBytes, err := ioutil.ReadFile(filePath)
+	assert.NoError(t, err)
+	return string(stringBytes)


always add a new line in the last return, let's also add it to our styleguide

Do you mean like this:

func getFileContent(t *testing.T, filePath string) string { stringBytes, err := ioutil.ReadFile(filePath) assert.NoError(t, err) return string(stringBytes) }

?

When there is only one line this should be ignored right?

func GetPi() float64 { return 3.14 }

repositories/tasks/memory/repository.go

Adopt Go 1.11 Modules as the dependency manager

77cbe1a

mlimaloureiro requested changes Jan 9, 2019

View reviewed changes

NMFR force-pushed the feature-26-export-to-ical branch 2 times, most recently from 534913f to 4582c34 Compare January 10, 2019 09:33

jsaguiar suggested changes Jan 10, 2019

View reviewed changes

NMFR force-pushed the feature-26-export-to-ical branch from ca4f20f to 91f3bd0 Compare January 11, 2019 10:49

Add export command and ical exporter

926f6e4

To export run: ```sh golog export ``` Or: ```sh golog export ical golog.ics ``` Closes mlimaloureiro#26

NMFR force-pushed the feature-26-export-to-ical branch 4 times, most recently from b98ada7 to 5b7a65b Compare January 16, 2019 16:42

NMFR added 2 commits January 16, 2019 16:54

Refacture Task and Repository model structure

01e92f3

NMFR force-pushed the feature-26-export-to-ical branch from 5b7a65b to 01e92f3 Compare January 16, 2019 17:02

NMFR changed the title ~~Feature #26 export to ical~~ [WIP] Feature #26 export to ical Jan 16, 2019

NMFR force-pushed the feature-26-export-to-ical branch from c2ba6a8 to 28bc77b Compare January 18, 2019 11:12

Refactor ICalTaskExporter into a TaskRepositoryInterface

67603ed

Add SetTask and SetTasks methods to TaskRepositoryInterface Implement the new TaskRepositoryInterface methods Add csv export format to the CLI Add comments to public structs / methods

NMFR force-pushed the feature-26-export-to-ical branch from 28bc77b to 67603ed Compare January 18, 2019 13:22

NMFR changed the title ~~[WIP] Feature #26 export to ical~~ [RFC] Feature #26 export to ical Jan 18, 2019

Refactor models and repositories folder structure

e2c1b2f

NMFR force-pushed the feature-26-export-to-ical branch from 90a15c3 to 5ba1867 Compare January 21, 2019 16:41

Create a service layer for the task repository

67eb470

Closes mlimaloureiro#7

NMFR force-pushed the feature-26-export-to-ical branch from 5ba1867 to 67eb470 Compare January 21, 2019 17:26

mlimaloureiro requested changes Jan 22, 2019

View reviewed changes

Fix codestyle issues

7360930

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Feature #26 export to ical #27

[RFC] Feature #26 export to ical #27

NMFR commented Jan 9, 2019

jsaguiar left a comment

mlimaloureiro Jan 22, 2019

NMFR Jan 22, 2019

mlimaloureiro Jan 22, 2019

NMFR Jan 22, 2019

mlimaloureiro Jan 22, 2019

NMFR Jan 22, 2019

mlimaloureiro Jan 22, 2019

NMFR Jan 22, 2019

[RFC] Feature #26 export to ical #27

Are you sure you want to change the base?

[RFC] Feature #26 export to ical #27

Conversation

NMFR commented Jan 9, 2019

jsaguiar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment