Nested mutation fails if parent row is not selected/updated #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is an issue on nested mutation, if you do not have the right to update the parent row. You end up trying to access a column of undefined there https://github.com/mlipscombe/postgraphile-plugin-nested-mutations/blob/master/src/PostgraphileNestedMutationsPlugin.js#L443
Here is a quick way to reproduce (may not be working yet, I'm on it):
Then perform a graphql nested mutation by creating a new
a
, and trying to connect it tob
. Since b cannot be updated, pgNestedTableConnect will return undefined.By the way, we create a
stable
branch, and tagsv1.1.0
(with fixes from #16, #24) andv1.1.1
(v1.1.0
+ current commit) on our own repository, since that one does not seem maintained anymore. We have several people working on graphile at Sterblue, and are relying a lot on nested mutations plugin.