Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sanitize parameter for Text widget #379

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Added sanitize parameter for Text widget #379

merged 5 commits into from
Mar 18, 2024

Conversation

spamsch
Copy link
Contributor

@spamsch spamsch commented Oct 19, 2023

Trying a fix for #303 as I need the Text widget to not sanitize sometimes.

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2023

CLA assistant check
All committers have signed the CLA.

@spamsch
Copy link
Contributor Author

spamsch commented Oct 19, 2023

When trying to test these changes I cannot get the worker in the browser to load. Everything looks fine after runnin mercury run and then navigating to my notebook. But it does not stop loading. Seems the web worker is not initializing correctly. No error messages in the browsers console.

@spamsch
Copy link
Contributor Author

spamsch commented Oct 20, 2023

Made more checks and it now works cleanly

Copy link
Contributor

@pplonski pplonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for PR. It looks good. One concern about .nvmrc file, do we need it?

frontend/.nvmrc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was struggling when compiling the frontend as my default node is v18. But compilation only works reliably with v16. So I added .nvmrc that acts a implicit documentation and one can just use nvm use before compiling.

@pplonski pplonski merged commit eff23a6 into mljar:main Mar 18, 2024
1 check passed
@pplonski
Copy link
Contributor

Thank you @spamsch 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants