-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sanitize parameter for Text widget #379
Conversation
When trying to test these changes I cannot get the worker in the browser to load. Everything looks fine after runnin |
Made more checks and it now works cleanly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for PR. It looks good. One concern about .nvmrc
file, do we need it?
frontend/.nvmrc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was struggling when compiling the frontend as my default node is v18. But compilation only works reliably with v16. So I added .nvmrc that acts a implicit documentation and one can just use nvm use
before compiling.
Thank you @spamsch 🥇 |
Trying a fix for #303 as I need the Text widget to not sanitize sometimes.