Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature & bug fix] Update openai library and add support to gpt4 #3

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

pedMatias
Copy link
Contributor

This commit brings 3 main changes:

  • Support to GPT4 and any other Openai model: You can pass the name of the model as an argument;
  • The last version of OpenAI python library didn't worked. Update the code;
  • Set the requirements to a version that I am sure it works.
  • The pytests run successfully;

Disclaimer: I only tested this code with Python3.10

@pedMatias pedMatias mentioned this pull request Mar 5, 2024
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@pplonski pplonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you! I think it is better to set model in constructor rather than in make() function, what do you think?

This commit brings 3 main changes:
- Support to GPT4 and any other Openai model: You can pass the name of the model as an argument;
- The last version of OpenAI python library didn't worked. Update the code;
- Set the requirements to a version that I am sure it works.
- The pytests run successfully;

Disclaimer: I only tested this code with Python3.10
@pedMatias
Copy link
Contributor Author

Hi @pplonski
Thanks! I made the changes you suggested. Let me know what you think
Cheers

Copy link
Contributor

@pplonski pplonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pplonski pplonski merged commit cce3ca8 into mljar:main Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants