Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getBinaryClassifiers function #16

Merged
merged 3 commits into from
Oct 29, 2021
Merged

feat: add getBinaryClassifiers function #16

merged 3 commits into from
Oct 29, 2021

Conversation

josoriom
Copy link
Member

No description provided.

@josoriom josoriom requested a review from lpatiny October 28, 2021 18:42
@lpatiny
Copy link
Member

lpatiny commented Oct 29, 2021

This code looks ok to me. If there are some references to R for the tests please add a comment so that we could reproduce it in R.

@josoriom
Copy link
Member Author

The roc and multiclass.roc functions of pROC library do not returns the binary classifiers in no case, and the multiclass.roc do not return sensitivities and specificities but all the results in the test cases were tested regarding this functions (In suitable cases I added the R code to be verified)

@josoriom josoriom merged commit 8e6c098 into mljs:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants