Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Carbon dependency #13

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Remove unused Carbon dependency #13

merged 5 commits into from
Apr 3, 2024

Conversation

mwikberg-virta
Copy link
Contributor

@mwikberg-virta mwikberg-virta commented Apr 3, 2024 •
edited
Loading

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Changes

Breaking changes

@mwikberg-virta mwikberg-virta changed the title Carbon 3..x Carbon 3.x Apr 3, 2024
@mwikberg-virta
Copy link
Contributor Author

mwikberg-virta commented Apr 3, 2024 •
edited
Loading

hmm.. actually the whole Carbon library seems to be unused 🤔 It's only required by Laravel, which has the versions defined anyway

@mwikberg-virta mwikberg-virta changed the title Carbon 3.x Remove unused Carbon dependency Apr 3, 2024
@mwikberg-virta mwikberg-virta reopened this Apr 3, 2024
@spawnia spawnia merged commit 925dcf5 into mll-lab:master Apr 3, 2024
54 of 58 checks passed
@spawnia
Copy link
Member

spawnia commented Apr 3, 2024

Thanks, released with https://github.com/mll-lab/laravel-utils/releases/tag/v4.12.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mwikberg-virta @spawnia