Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle long vectors in min/max checking. #231

Merged
merged 1 commit into from Jul 28, 2022
Merged

Conversation

rorynolan
Copy link
Contributor

With the current package, the following code

checkmate::assert_numeric(rep(0, 2^33), min = 0)

produces the error

Error in checkmate::assert_numeric(img, lower = 0) :
long vectors not supported yet: ../../src/include/Rinlinedfuns.h:537

Changing a couple of length()s to xlength()s in checks.c fixes this.

@mllg
Copy link
Owner

mllg commented Jul 28, 2022

Thanks! Note that there are likely to be more issues with long vectors, I need to test this thoroughly as soon as I find the time.

@mllg mllg merged commit dfccdcc into mllg:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants