Skip to content

Handle long vectors in min/max checking.#231

Merged
mllg merged 1 commit intomllg:masterfrom
rorynolan:master
Jul 28, 2022
Merged

Handle long vectors in min/max checking.#231
mllg merged 1 commit intomllg:masterfrom
rorynolan:master

Conversation

@rorynolan
Copy link
Copy Markdown
Contributor

With the current package, the following code

checkmate::assert_numeric(rep(0, 2^33), min = 0)

produces the error

Error in checkmate::assert_numeric(img, lower = 0) :
long vectors not supported yet: ../../src/include/Rinlinedfuns.h:537

Changing a couple of length()s to xlength()s in checks.c fixes this.

@mllg
Copy link
Copy Markdown
Owner

mllg commented Jul 28, 2022

Thanks! Note that there are likely to be more issues with long vectors, I need to test this thoroughly as soon as I find the time.

@mllg mllg merged commit dfccdcc into mllg:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants