Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an independent npm module out of it #46

Closed
steffenmllr opened this issue Jan 21, 2014 · 20 comments
Closed

Create an independent npm module out of it #46

steffenmllr opened this issue Jan 21, 2014 · 20 comments
Labels

Comments

@steffenmllr
Copy link
Contributor

As I want to support gulp and grunt, it would make sense to port the builder into a separate npm module and only make a wrapper for grunt and gulp -> https://github.com/mllrsohn/node-webkit-builder

@adam-lynch
Copy link
Contributor

👍

@GiorgioPingendo
Copy link

👍👍

@feross
Copy link

feross commented Mar 28, 2014

👍

What's the progress on this? Does node-webkit-builder have parity yet?

@feross
Copy link

feross commented Mar 28, 2014

I may be able to help out with this. What needs to be done?

@steffenmllr
Copy link
Contributor Author

@feross have a look at the repo / tests. one prob is that the "get-latest-version" stuff doesn't work anymore (because nw isn't hosted on aws anymore), the cli stuff is missing and that's about it - the rest should work.

@ivantodorovich
Copy link

@feross Are you sure about nw not being hosted in aws?

I don't know the status of nw 14 days ago, but it is hosted now.

This is taken from nodewebkit's install.js script, and tested on windows:

// Determine download url
if (process.platform === 'darwin') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-osx-ia32.zip';
} else if (process.platform === 'win32') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-win-ia32.zip';
} else if (process.arch === 'ia32') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-ia32.tar.gz';
} else if (process.arch === 'x64') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-x64.tar.gz';
}

@steffenmllr
Copy link
Contributor Author

nw was hostet on aws - it's not anymore - so the auto-get-newest-version needs some work. Maybe ask rogerwang in #68 if he could provide a json with the dir list or maybe parse the github release api...

@ivantodorovich
Copy link

The install script I posted successfully downloads nw binaries. Tested on win7
http://s3.amazonaws.com/node-webkit/v0.9.2/node-webkit-v0.9.2-linux-x64.tar.gz
Downloads just fine

@steffenmllr
Copy link
Contributor Author

hmm we should ask rogerwang if it's ok to use the aws link

@ivantodorovich
Copy link

I think there shouldn't be any problems.. Its the same he uses for npm
install nodewebkit
El abr 10, 2014 6:36 PM, "Steffen Müller" notifications@github.com
escribió:

hmm we should ask rogerwang if it's ok to use the aws link

Reply to this email directly or view it on GitHubhttps://github.com//issues/46#issuecomment-40146025
.

@steffenmllr
Copy link
Contributor Author

There is also still some stuff left to at: https://github.com/mllrsohn/node-webkit-builder

  • the cli stuff
  • testing

I'm pretty full the next weeks with client work so any help is appreciated :)

@ivantodorovich
Copy link

Ok, I'll try to help :)

@steffenmllr
Copy link
Contributor Author

There you go: https://github.com/mllrsohn/node-webkit-builder
There might be some bug, so some feedback would be nice :)

@steffenmllr
Copy link
Contributor Author

@adam-lynch you can get rid of grunt now - would be great if you could test the first version

@adam-lynch
Copy link
Contributor

giphy

@steffenmllr Great! I'll test this when I get a chance. What kind of bugs should I look out for?

@steffenmllr
Copy link
Contributor Author

make sure it works on linux and windows
make sure you install with npm install mllrsohn/node-webkit-builderto get the latest version from github, I'll try to get a code coverage tool to see where the bilnd spots are.

@dgattey
Copy link

dgattey commented Jun 24, 2014

What''s the status of this?

@konsumer
Copy link

konsumer commented Jul 7, 2014

I'd love to help with a brunch version, too, using the same lib.

@steffenmllr
Copy link
Contributor Author

@konsumer pls check: https://github.com/mllrsohn/node-webkit-builder there is one bug in the linux build everything else should work I don't really have a lot of time atm so help is appreciated

@gabepaez
Copy link
Contributor

gabepaez commented Aug 2, 2014

done. b9cbf4c

@gabepaez gabepaez closed this as completed Aug 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants