-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an independent npm module out of it #46
Comments
👍 |
👍👍 |
👍 What's the progress on this? Does node-webkit-builder have parity yet? |
I may be able to help out with this. What needs to be done? |
@feross have a look at the repo / tests. one prob is that the "get-latest-version" stuff doesn't work anymore (because nw isn't hosted on aws anymore), the cli stuff is missing and that's about it - the rest should work. |
@feross Are you sure about nw not being hosted in aws? I don't know the status of nw 14 days ago, but it is hosted now. This is taken from nodewebkit's install.js script, and tested on windows:
|
nw was hostet on aws - it's not anymore - so the auto-get-newest-version needs some work. Maybe ask rogerwang in #68 if he could provide a json with the dir list or maybe parse the github release api... |
The install script I posted successfully downloads nw binaries. Tested on win7 |
hmm we should ask rogerwang if it's ok to use the aws link |
I think there shouldn't be any problems.. Its the same he uses for npm
|
There is also still some stuff left to at: https://github.com/mllrsohn/node-webkit-builder
I'm pretty full the next weeks with client work so any help is appreciated :) |
Ok, I'll try to help :) |
There you go: https://github.com/mllrsohn/node-webkit-builder |
@adam-lynch you can get rid of grunt now - would be great if you could test the first version |
@steffenmllr Great! I'll test this when I get a chance. What kind of bugs should I look out for? |
make sure it works on linux and windows |
What''s the status of this? |
I'd love to help with a brunch version, too, using the same lib. |
@konsumer pls check: https://github.com/mllrsohn/node-webkit-builder there is one bug in the linux build everything else should work I don't really have a lot of time atm so help is appreciated |
done. b9cbf4c |
As I want to support gulp and grunt, it would make sense to port the builder into a separate npm module and only make a wrapper for grunt and gulp -> https://github.com/mllrsohn/node-webkit-builder
The text was updated successfully, but these errors were encountered: