Spaces in File Path

[RDalziel]

I've been currently working on a TFS Build which will spin up selenium and run protractor tests against a deployment.

Whilst setting this up, i noticed that if my folder path for where the node_modules folder is located contains a space, gulp protractor bombs out when trying to reference one of the file paths.

For example:

'c:\dev\folder\node_modules\gulp-protractor' works absolutely fine
'c:\dev\new folder\node_modules\gulp-protractor' will throw an error along the lines of 'c:\dev\new' is an unrecognised command'

I managed to get round the error by just re-working how my folder paths are named, but thought i'd mention anyway!

[Freundschaft]

same issue here as well, the plugin doesnt work well with spaces in file path

[GustavSt]

I got this issue as well, the problem for we is it's in my User folder and my user name contains a space..

[jeroenlorrentop]

Any news on this issue?

[mattfritz]

I'll take a look at this later this week, thanks for the detailed report.

[AdamWillden]

@mattfritz any news? I'm encountering the same issue

[mattfritz]

I have changes pushed to the windows-path-support branch. Can someone with a Windows box clone this repo, check out windows-path-support, and use npm link to test the changes? I don't have access to a Windows machine. Let me know and I'll integrate it. Thanks!

[Charlynux]

Hello @mattfritz,

Get the same error, so I give a try to your solution.

First, child_process.exec seems to don't take "args" argument. According to this documentation, child_process.execFile does.
Not being a Node.js expert, I can't say what's the impact to change from one to another.

Just in case, I replace exec by execFile and get another error :

Error: Cannot find module 'C:\Program Files (x86)\...\workspace\node_modules\gulp-protractor\node_modules\.bin\protractor.conf.js'

Working directory being : "C:\Program Files...", Protractor search my config file in this directory.

To correct this I just wrap options.configFile with path.resolve :

// Pass in the config file
if (options.configFile) {
      args.unshift(path.resolve(options.configFile));
}

Now it seems to work. Hope this help you.

[Charlynux]

I just realised : with execFile, I lose stdout.
Rolling back to spawnrestore stdout and continue to fixing the "space path" problem.

[slx2005]

@Charlynux by any chance have you found any other fix?

[Charlynux]

I discover that changing the working directory (via cwd option) have some drawbacks. In my case, I use a plugin for screenshots and pictures are saved relative to the working directory.
I made some tests, but was not able to find another way to correct the problem.

So, I just move my Jenkins directory to a path without space...

[davidwickman]

I have a PR in for this fix.
#112

[alexfromapex]

+1 This is also affecting me on Windows