Force checking response signature (#6)

mlocati · Jun 15, 2023 · 53a0b45 · 53a0b45
1 parent 115544b
commit 53a0b45
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -65,7 +65,6 @@ $response = $client->init($request);
 if ($response->getRc() !== RC::TRANSACTION_OK || $response->isError() || $response->getRedirectURL() === '') {
     throw new \Exception('Transaction failed: ' . $response->getErrorDesc());
 }
-$response->checkSignature('Your kSig digital signature');
 ```
 
 At this point, you you have a succesfull initialization response.
@@ -113,9 +112,6 @@ $response = $client->verify($request);
 if ($response->getRc() !== RC::TRANSACTION_OK || $response->isError()) {
     throw new \Exception('Transaction failed: ' . $response->getErrorDesc());
 }
-
-$response->checkSignature('Your kSig digital signature');
-
 ```
 
 ## Server2Server communication (callback URL)

diff --git a/src/Client.php b/src/Client.php
@@ -105,8 +105,12 @@ public function init(Init\Request $request)
         if (!$rawResponse->is2xx()) {
             throw new Exception\InvalidHttpResponseCode($rawResponse);
         }
+        $response = $this->getInitUnserializer()->unserialize($rawResponse->getBody());
+        if (!$response->isError() || $response->getSignature() !== '') {
+            $response->checkSignature($this->signatureKey);
+        }
 
-        return $this->getInitUnserializer()->unserialize($rawResponse->getBody());
+        return $response;
     }
 
     /**
@@ -119,8 +123,12 @@ public function verify(Verify\Request $request)
         if (!$rawResponse->is2xx()) {
             throw new Exception\InvalidHttpResponseCode($rawResponse);
         }
+        $response = $this->getVerifyUnserializer()->unserialize($rawResponse->getBody());
+        if (!$response->isError() || $response->getSignature() !== '') {
+            $response->checkSignature($this->signatureKey);
+        }
 
-        return $this->getVerifyUnserializer()->unserialize($rawResponse->getBody());
+        return $response;
     }
 
     /**