Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

peter279k
Copy link

Changed log

  • Merge composer-travis-ci.json to composer.json.
  • Using class-based PHPUnit namespace to be compatible with latest PHPUnit versions.
  • Define multiple PHPUnit versions to support different PHP versions.

@mlocati
Copy link
Owner

mlocati commented Nov 13, 2018

We are missing coveralls in the new composer.json.
I think we need something like what I did in mlocati/ip-lib#21

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 73.931% when pulling c0d40b4 on peter279k:test_enhancement into bff03c0 on mlocati:master.

@peter279k
Copy link
Author

peter279k commented Nov 13, 2018

@mlocati, thank you for your comment.

I've added the "php-coveralls/php-coveralls": "^1.0" in composer.json and try to add the coveralls service back.

But it looks like the coveralls service has been broken because the code coverage percent is reduced.

It's strange because I don't do anything big changes for tests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants