Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent problems while installing package #921

Closed
wants to merge 1 commit into from

Conversation

jeff1326
Copy link

No description provided.

@mlocati
Copy link
Owner

mlocati commented May 14, 2024

Could you provide more details about this change? Why is it required?

@jeff1326
Copy link
Author

@mlocati Unfortunately no. My co-worker did the changes on a older version of this repository. He told me he added these almost everywhere until it works and he don't remember which specific package was causing the issue.

As i see this, this won't break anything at least.

@tarlepp
Copy link

tarlepp commented May 14, 2024

@jeff1326
Copy link
Author

That ACCEPT_EULA=Y sounds like mssql related configuration.

https://learn.microsoft.com/en-us/sql/linux/quickstart-install-connect-docker?view=sql-server-ver16&tabs=cli&pivots=cs1-bash#run-the-container-2

That would make sense since we use it in some projet

@tarlepp
Copy link

tarlepp commented May 14, 2024

although that accept eula thing should not be happen if you're just installing pdo extension for that - not 100% sure about this.

@mlocati
Copy link
Owner

mlocati commented May 14, 2024

AFAIK the ACCEPT_EULA environment variable should be set to install msodbcsql in an unattended way.
But we should already do that: msodbcsql is already being installed without any issue, isn't it?

I won't set a variable nobody knows why and when it should be set...

@mlocati mlocati closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants