Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RFC conformance of the "include" mechanism #10

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

mlocati
Copy link
Owner

@mlocati mlocati commented Jul 15, 2020

No description provided.

@mlocati mlocati force-pushed the improve-include-conformance branch from bb1181e to 80f5164 Compare July 15, 2020 16:36
@codecov-commenter
Copy link

Codecov Report

Merging #10 into master will decrease coverage by 2.44%.
The diff coverage is 37.20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
- Coverage     90.20%   87.75%   -2.45%     
- Complexity      526      550      +24     
============================================
  Files            35       36       +1     
  Lines          1133     1176      +43     
============================================
+ Hits           1022     1032      +10     
- Misses          111      144      +33     
Flag Coverage Δ Complexity Δ
#unittests 87.75% <37.20%> (-2.45%) 550.00 <39.00> (+24.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/Check/Result.php 82.60% <0.00%> (-17.40%) 13.00 <2.00> (+2.00) ⬇️
src/Check/State.php 100.00% <ø> (ø) 13.00 <0.00> (ø)
src/Exception/IncludeMechanismException.php 0.00% <0.00%> (ø) 5.00 <5.00> (?)
src/Checker.php 74.25% <47.05%> (-4.84%) 117.00 <32.00> (+17.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909b35d...b5f9ec8. Read the comment docs.

@mlocati mlocati force-pushed the improve-include-conformance branch from 80f5164 to b5f9ec8 Compare July 15, 2020 16:53
@mlocati mlocati merged commit c752916 into master Jul 15, 2020
@mlocati mlocati deleted the improve-include-conformance branch July 15, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants