Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for bentofile json schema #7

Merged
merged 4 commits into from Mar 23, 2024

Conversation

phitoduck
Copy link
Contributor

Overview

I wrote a trivial unit test for validating the bentofile.yaml and did a lot of work to make it easy to use the "Test Explorer" sidebar for running and step-debugging individual tests.

image

I included a guide in the README on the various ways to run tests. Hopefully this reduces the friction for authoring tests for all of our future PRs!

Commits

  • feat: added dev dependencies on ajv (json schema validation lib); mocha-test-explorer-launch-scripts (displaying tests in sidebar); ts-node (setting breakpoints in TS tests)
  • feat: iterated on bentofileSchema.json and added a trivial test
  • test: configured Mocha Test Explorer for VS Code in settings.json
  • docs: added guide on testing to the README

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.89%. Comparing base (a64078f) to head (bb73fad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   26.89%   26.89%           
=======================================
  Files          18       18           
  Lines        1937     1937           
  Branches        2        2           
=======================================
  Hits          521      521           
  Misses       1416     1416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phitoduck phitoduck merged commit abb6d94 into main Mar 23, 2024
7 checks passed
@phitoduck phitoduck deleted the add-test-for-bentofile-json-schema branch March 23, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant