Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(V1) Fix #20 by delete the day of suspension trading. #21

Closed
wants to merge 17 commits into from

Conversation

TCCinTaiwan
Copy link
Contributor

mlouielu#20
假如'開盤價'為'--'就跳過
test ValueError becuse json.decoder.JSONDecodeError not exist before version 3.5.
@TCCinTaiwan
Copy link
Contributor Author

TCCinTaiwan commented Oct 14, 2017

by the way,

except json.decoder.JSONDecodeError:
also have the same problem that JSONDecodeError don't exist before python 3.4.x.
if https://github.com/mlouielu/twstock/blob/master/test/test_stock.py either have a function like test_stock_get_bad_id, I think the ci test wouldn't pass either.

@TCCinTaiwan TCCinTaiwan changed the title V1 remove the day Fix #20 by delete the day of suspension trading. And join the calculation of Stochastic Oscillator function. Oct 17, 2017
@TCCinTaiwan
Copy link
Contributor Author

Sorry, I accidentally merge the Stochastic Oscillator into V1, so I will close this Pull request and create a new one later.

@TCCinTaiwan TCCinTaiwan changed the title Fix #20 by delete the day of suspension trading. And join the calculation of Stochastic Oscillator function. Fix #20 by delete the day of suspension trading. Oct 17, 2017
@TCCinTaiwan TCCinTaiwan changed the title Fix #20 by delete the day of suspension trading. (V1) Fix #20 by delete the day of suspension trading. Oct 17, 2017
@TCCinTaiwan TCCinTaiwan deleted the v1-remove-the-day branch October 17, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to extract historical data on certain stocks
1 participant