Strip all fields for StockCodeInfo #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlouielu
reviewed
Mar 12, 2018
twstock/codes.py
Outdated
| @@ -29,11 +29,12 @@ def read_csv(path, types): | |||
| csvfile.readline() | |||
| for row in reader: | |||
| row = ROW(*row) | |||
There was a problem hiding this comment.
Can we strip the code at this line like ROW(*row.strip()) so that we don't need to deal with other parts?
There was a problem hiding this comment.
You mean strip all fields?
I will do that later.
|
I'll merge this PR. Again, thanks @ianlini for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some codes in the CSV files has white space after the codes, 4148 for example:
股票,4148 ,全宇生技-KY,KYG0232P1072,2017/06/08,上市,生技醫療業,ESVUFRin the
twse_equities.csv.Because of this,
Stock('4148')cannot get the correct result.It's actually a problem in the original CSV files, but I don't know where you got them, so I don't change them.
It would be better to validate and handle all the values in the files or the data we fetch.
Because I actually have my own database for the stock information, I only do a workaround here so that I can use
Stock().