This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Implement heartbeat-based EventSource connection reset #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
work on some potential tests can be found on another branch here: https://github.com/mlp6/ADPL/tree/s/heartbeat-potential-tests but some additional refactors will probably be needed to best test this heartbeat. Likely this module should be refactored into an ES6 class. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #156 by creating a heartbeat timer that will reset the SSE connection to particle if a certain number of messages are not received every heartbeat interval.