Implement Field II Pro C hooks #51
Conversation
fieldC/dynaField.c
Outdated
|
|
||
| /* foo = (double *)malloc(26*1344*sizeof(double)); */ | ||
|
|
||
| xdc_get(Th, info, foo); |
There was a problem hiding this comment.
@ndanieley says something here isn't working as expected (or we don't know what it expected)
in fieldC, you'll get an a.out that can be used for testing.
|
|
||
| for (i = 0; i < numNodes; i++) | ||
| if (pointsAndNodes[i].x == 0 && pointsAndNodes[i].y == 0) { | ||
| found = 1; |
There was a problem hiding this comment.
We should try to add some unit tests to validate the function of all of these things... especially since the majority of students in the lab are not as familiar w/ C-syntax, things can become much more susceptible to innocent bug introduction w/ syntax issues.
There was a problem hiding this comment.
are you suggesting that someone might modify my code? hmmmph.
maybe I'll work on some tests while I'm waiting to understand xdc_get; I'll see what I can come up with.
There was a problem hiding this comment.
Nope - additional code that runs yours to test it against some known outcomes... but then in the future when folks may dabble with changing the code, they have some reference tests that should still pass.
Conflicts: fieldC/dynaField.c trying to fix up my changes with David's
…the data to a file, but there's still a fair amount of work to be done.
… script to read my output file format into matlab (readDyna.m). I need to finish up the field2dyna conversion, and do a lot of cleanup.
|
@ndanieley @davidbradway we should do an in-person code review of all of this once it is ready I can / will try to replicate functionality on my own this weekend after I get all of my grading done. |
|
I will be available and in the office starting Monday
…On Thu, May 3, 2018, 11:16 AM Mark Palmeri ***@***.***> wrote:
@ndanieley <https://github.com/ndanieley> @davidbradway
<https://github.com/davidbradway> we should do an in-person code review
of all of this once it is ready I can / will try to replicate functionality
on my own this weekend after I get all of my grading done.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEjUygkq1Dbn3DABoTY667Cx2gR7wu-7ks5tux8ugaJpZM4S_nZj>
.
|
…ht have been some other cleanup, too.
* fixes issue with compiling Field II Pro code on LinuxMint systems (that are Ubuntu derivatives) [fixes #62] * rm platform-specific object files that conflict on different systems
'verbose'. also added ability to set verbose option in main.
dynaField in field2dyna.
the probe file to be under the transducer type. that does cause some duplication of code, but I think it's the clearest way.
been calling xdc_focused_array. that's fixed now.
…e to read in the experimental impulse.
…l in readExpData(), so after this commit, I'm going to separate the formatting code (which produces the impulse response) from the code that just reads the data. I also fixed a problem in argument processing in main.c
No description provided.