Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffle parameter in spsa is not used #114

Closed
coatless opened this issue May 20, 2019 · 1 comment
Closed

shuffle parameter in spsa is not used #114

coatless opened this issue May 20, 2019 · 1 comment
Labels
s: fixed t: bug report

Comments

@coatless
Copy link
Contributor

coatless commented May 20, 2019 •
edited

Issue description

The shuffle parameter in spsa is not used.

 ../inst/include/ensmallen_bits/spsa/spsa.hpp:120:8: 
warning: private field 'shuffle' is not used [-Wunused-private-field]
  bool shuffle;
       ^

Your environment

  • version of ensmallen: 1.15.0
  • operating system: macOS
  • compiler: clang 7.0.0
  • version of Armadillo: 9.400
  • any other environment information you think is relevant:

Steps to reproduce

Compile ensmallen.
@coatless coatless mentioned this issue May 20, 2019
Merged
@rcurtin
Copy link
Member

rcurtin commented Jun 1, 2019

Since #115 is merged, this is now solved. Thanks for the PR. 👍

@rcurtin rcurtin closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s: fixed t: bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coatless @rcurtin