Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`shuffle` parameter in `spsa` is not used #114

Closed
coatless opened this issue May 20, 2019 · 1 comment

Comments

@coatless
Copy link
Contributor

commented May 20, 2019

Issue description

The shuffle parameter in spsa is not used.

 ../inst/include/ensmallen_bits/spsa/spsa.hpp:120:8: 
warning: private field 'shuffle' is not used [-Wunused-private-field]
  bool shuffle;
       ^

Your environment

  • version of ensmallen: 1.15.0
  • operating system: macOS
  • compiler: clang 7.0.0
  • version of Armadillo: 9.400
  • any other environment information you think is relevant:

Steps to reproduce

Compile ensmallen.

@rcurtin

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Since #115 is merged, this is now solved. Thanks for the PR. 👍

@rcurtin rcurtin closed this Jun 1, 2019

@rcurtin rcurtin added s: fixed and removed s: unanswered labels Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.