PSO variable type buglet

[coatless]

Issue description

Mismatch on return types in PSO

../inst/include/ensmallen_bits/pso/pso.hpp: In member function ‘size_t ens::PSOType<VelocityUpdatePolicy, InitPolicy>::LowerBound() const’:
../inst/include/ensmallen_bits/pso/pso.hpp:162:38: error: cannot convert ‘const vec’ {aka ‘const arma::Col<double>’} to ‘size_t’ {aka ‘long unsigned int’} in return
  162 |   size_t LowerBound() const { return lowerBound; }
      |                                      ^~~~~~~~~~

Defined as arma::vec:

ensmallen/include/ensmallen_bits/pso/pso.hpp

Lines 207 to 210 in b46986d

	//! Lower bound of the initial swarm.
	arma::vec lowerBound;
	//! Upper bound of the initial swarm.
	arma::vec upperBound;

But returning size_t:

ensmallen/include/ensmallen_bits/pso/pso.hpp

Lines 161 to 171 in b46986d

	//! Retrieve value of lowerBound.
	size_t LowerBound() const { return lowerBound; }
	//! Modify value of lowerBound.
	size_t& LowerBound() { return lowerBound; }
	//! Retrieve value of upperBound.
	size_t UpperBound() const { return upperBound; }
	//! Modify value of upperBound.
	size_t& UpperBound() { return upperBound; }

Your environment

• version of ensmallen: 1.16.0
• operating system: debian
• compiler: gcc-9
• version of Armadillo: 9.600

[zoq]

Thanks for the report, should be fixed in #124, I will put some time into the test setup, so that we can avoid such issues in the future.

[rcurtin]

Fixed in #124. Thanks for the report. 👍

[rcurtin]

Ah, I discovered that #126 will also be necessary here.

[coatless]

@rcurtin sorry about that. I should have grabbed the entire log. :/

[mlpack-bot]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

[coatless]

Closed in #126 and #123