Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure armadillo version check uses the same numbers as CMakeLists.txt #133

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@conradsnicta
Copy link
Contributor

commented Sep 11, 2019

CMakeLists.txt enforces Armadillo 8.400, so for consistency we need to do that in include/ensmallen.hpp as well

https://github.com/mlpack/ensmallen/blob/master/CMakeLists.txt#L55

@mlpack-jenkins

This comment has been minimized.

Copy link

commented Sep 11, 2019

Can one of the admins verify this patch?

@zoq

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Strange haven't seen the "Can one of the admins verify this patch?" message in a long time; let's see what happens if I delete it from the config.

@zoq
zoq approved these changes Sep 11, 2019
Copy link
Member

left a comment

Looks good to me.

Copy link
Member

left a comment

I hadn't realized we were checking Armadillo versions in this file; I'll be sure to make sure it gets updated in the future. :) Thanks!

@rcurtin rcurtin merged commit 222ce84 into mlpack:master Sep 11, 2019
2 checks passed
2 checks passed
Static Code Analysis Checks Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.