Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch2 update 2.13.4 #268

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Catch2 update 2.13.4 #268

merged 3 commits into from
Mar 10, 2021

Conversation

zoq
Copy link
Member

@zoq zoq commented Mar 7, 2021

Catch2 update 2.13.4 which will fix #266.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the memory tests are failing (looks like they ran fine); the static code analysis issues can be ignored; and the Windows build issues appear to be #267 (so this PR wouldn't solve them anyway). So, looks good otherwise! 😄

@zoq
Copy link
Member Author

zoq commented Mar 9, 2021

I'm not sure why the memory tests are failing (looks like they ran fine); the static code analysis issues can be ignored; and the Windows build issues appear to be #267 (so this PR wouldn't solve them anyway). So, looks good otherwise!

The memory job run into the build timeout which is set to 360 minutes, usually we just run the memory check on changed tests, but since an update of the catch2 header will trigger all tests to be run we run into the timeout. But agreed, save to ignore in this case.

@rcurtin
Copy link
Member

rcurtin commented Mar 9, 2021

Ahh, ok, thanks---I must have just missed the 'job terminated' line in the log. 👍

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded assembly code not working for Apple M1
2 participants