Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LBFGS: avoid generation of NaNs, and add checks for finite values #368

Merged
merged 4 commits into from Jun 23, 2023
Merged

LBFGS: avoid generation of NaNs, and add checks for finite values #368

merged 4 commits into from Jun 23, 2023

Conversation

conradsnicta
Copy link
Contributor

@conradsnicta conradsnicta commented Jun 21, 2023 •
edited

related to #365

@conradsnicta conradsnicta changed the title avoid generation of NaNs, and add checks for finite values LBFGS: avoid generation of NaNs, and add checks for finite values Jun 21, 2023
@conradsnicta conradsnicta mentioned this pull request Jun 21, 2023
Closed
rcurtin
rcurtin reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this---just some small comments. 👍

include/ensmallen_bits/lbfgs/lbfgs_impl.hpp Outdated Show resolved Hide resolved
include/ensmallen_bits/lbfgs/lbfgs_impl.hpp Show resolved Hide resolved
rcurtin
rcurtin approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, no more comments from my side. 👍

zoq
zoq approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@conradsnicta conradsnicta merged commit 2e0ab12 into mlpack:master Jun 23, 2023
0 of 2 checks passed
@rcurtin rcurtin mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@zoq zoq zoq approved these changes

@coatless coatless Awaiting requested review from coatless

@shrit shrit Awaiting requested review from shrit

Assignees
No one assigned
Labels
c: optimizers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@conradsnicta @rcurtin @zoq