Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the pendulum notebook #108

Merged
merged 2 commits into from Jul 29, 2020
Merged

Added the pendulum notebook #108

merged 2 commits into from Jul 29, 2020

Conversation

nishantkr18
Copy link
Member

For running the notebook, please have a look here: zoq/gym_tcp_api#14 (comment)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

favre49
favre49 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@favre49 favre49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it a couple times as well, seemed alright to me. Only some small things, and I think we can merge it.

q_learning/pendulum_dqn.ipynb Outdated Show resolved Hide resolved
q_learning/pendulum_dqn.ipynb Outdated Show resolved Hide resolved
@zoq zoq removed the s: unanswered label Jul 29, 2020
zoq
zoq approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@zoq zoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, fantastic example; tested the trained agent multiple times as well, the agent was able to solve the env everytime, and that with such a limited action space, nicely done.

@zoq zoq merged commit c86ac51 into mlpack:master Jul 29, 2020
@nishantkr18 nishantkr18 deleted the pendulum branch July 29, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoq zoq zoq approved these changes

@favre49 favre49 favre49 approved these changes

Assignees
No one assigned
Labels
c: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nishantkr18 @zoq @favre49