Merge pull request #2803 from rcurtin/model-no-visitor

Remove boost::visitor from `Model` classes
mlpack · Feb 7, 2021 · f96934d · f96934d
2 parents 3b74b94 + b7f614a
commit f96934d
Show file tree

Hide file tree

Showing 32 changed files with 3,450 additions and 3,458 deletions.
diff --git a/COPYRIGHT.txt b/COPYRIGHT.txt
@@ -7,7 +7,7 @@ Source:
 
 Files: *
 Copyright:
-  Copyright 2008-2020, Ryan Curtin <ryan@ratml.org>
+  Copyright 2008-2021, Ryan Curtin <ryan@ratml.org>
   Copyright 2008-2013, Bill March <march@gatech.edu>
   Copyright 2008-2012, Dongryeol Lee <dongryel@cc.gatech.edu>
   Copyright 2008-2013, Nishant Mehta <niche@cc.gatech.edu>

diff --git a/HISTORY.md b/HISTORY.md
@@ -19,11 +19,14 @@
   * HMM: add functions to calculate likelihood for data stream with/without
     pre-calculated emission probability (#2142).
 
-  * Replace Boost serialization library by Cereal (#2458).
+  * Replace Boost serialization library with Cereal (#2458).
 
   * Add `PYTHON_INSTALL_PREFIX` CMake option to specify installation root for
     Python bindings (#2797).
 
+  * Removed `boost::visitor` from model classes for `knn`, `kfn`, `cf`,
+    `range_search`, `krann`, and `kde` bindings (#2803).
+
   * Add k-means++ initialization strategy (#2813).
 
   * `NegativeLogLikelihood<>` now expects classes in the range `0` to

diff --git a/src/mlpack/methods/cf/CMakeLists.txt b/src/mlpack/methods/cf/CMakeLists.txt
@@ -5,6 +5,7 @@ set(SOURCES
   cf_impl.hpp
   cf_model.hpp
   cf_model_impl.hpp
+  cf_model.cpp
   svd_wrapper.hpp
   svd_wrapper_impl.hpp
 )