-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Windows installer fixes/changes #1506
Comments
Another improvement might be to remove the *_test.exe and the test dependency (boost_unit_test_framework-vc140-mt-1_60.dll). Having the test in the installer may not be that useful (and it fails anyways because it can't find many test files). |
Hi @rcurtin. In work list, the 1 and 2 have been done and the 3 almost has been done. To use the git version in build, the version should be
Because the possible minimum and maximum character pairs are So, is it proper way to converting it?? |
Hehe, @KimSangYeon-DGU, thanks for the extensive analysis. But I was thinking something much simpler, just like we do for existing Linux builds. :) Basically we just use the git hash... so if the hash is |
With #1506 merged, we can close this now. Thanks @KimSangYeon-DGU! 👍 |
These are just a few leftover changes from #1485. They aren't high priority but I don't think any of them are too hard.
This could be a nice intro task for someone with some Windows knowledge who wants to contribute.
The text was updated successfully, but these errors were encountered: