FastMKS segfault fix #1986
Merged
FastMKS segfault fix #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I dug into #1767 and found that the issue is actually not the fact that the hyperbolic tangent kernel is only conditionally positive definite. Instead, for the optdigits dataset, the issue is that the dot product between each point is sufficiently large that every kernel evaluation is identical---meaning that the distance between points is always 0.
This then means that the cover tree gets built in a weird way that is actually invalid. So I fixed this bug in e584aea.
While I was in there, I also made the FastMKS binding check for a valid value of k, if it is passed, and added a test for it. And I hid the
Log::Fataloutput from the one test that tries to loadnonexistentfile.arff. :)