Fix Julia documentation. #2373
Merged
Fix Julia documentation. #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Apr 18, 2020
rcurtin
reviewed
Apr 18, 2020
There was a problem hiding this comment.
Hey @Yashwants19, thanks for writing up a quick fix for this. It looks good to me, just one comment about the Python bindings and I think it should be good to go. (Also, maybe we should add something to HISTORY.md?)
Yashwants19
force-pushed
the
Fix-Julia-Doc
branch
from
97147e6
to
54bf174
Compare
|
Hi @rcurtin I have updated |
|
Awesome, thank you! 👍 Let's make sure the build passes, then I'll approve and merge. :) |
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
|
When 3.3.1 is released, this should be propagated to the stable documentation pages. Tonight, the website rebuild should update the mlpack-git documentation. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to fix Julia documentation as discussed with @rcurtin. The
info,help,versionandcopy_all_inputsinputs aren't actually a part of the Julia binding as printed in the binding documentation.