New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Doxygen warnings #2400
Fix Doxygen warnings #2400
Conversation
@@ -344,9 +344,9 @@ For further documentation on the DTree class, consult the | |||
The usual regularized error \f$R_\alpha(t)\f$ of a node \f$t\f$ is given by: | |||
\f$R_\alpha(t) = R(t) + \alpha |\tilde{t}|\f$ where | |||
|
|||
\f[ | |||
\f{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why this fixed this, or why it was an issue. Not a latex person.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember right \f{
wil not center the formula, really strange that we get a warning here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@birm you are my hero! This has needed to happen for way too long and I'm really appreciative that you just went and did it. I left some comments throughout (all of them should be easy I think!).
I noticed that in many places you added directories to the @file
annotations. Do we want to add a 'general rule' about that? Where, e.g., all of the @file
annotations start from under src/
? e.g. @file mlpack/core.hpp
or @file mlpack/bindings/cli/param.hpp
, etc. Maybe that could be more consistent. Let me know what you think. 👍
src/mlpack/methods/reinforcement_learning/q_networks/simple_dqn.hpp
Outdated
Show resolved
Hide resolved
src/mlpack/methods/softmax_regression/softmax_regression_function.hpp
Outdated
Show resolved
Hide resolved
thanks @rcurtin Co-authored-by: Ryan Curtin <ryan@ratml.org>
Thanks both @zoq and @rcurtin for looking over this giant PR! |
I thought it would be super tedious to use a full path, but, then I realized it's really easy to write a script to do it:
(It could probably be done entirely with You can run that from |
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
the idea of having the full paths in \file looks good to me now that it's done. On a quick look, I didn't notice any cases where this made the line too long. |
Let me rerun the failed ci jobs. |
For some reason the job keeps failing, but not only for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files changed: 1,207
😮
Anyway, looks good to me. I'm not bothered by the randomly failing build (it doesn't seem related to this PR, at least). Thank you for putting in the time to get this all worked out! 👍
Let me pull in upstream changes... Now it's a 1209, which is cool because 1209 divides 92^2 - 1 (I was hoping for a more interesting fact about 1209 from wolfram...) |
I tried Wikipedia; 1209 turns out to be the year Cambridge University was founded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is just great, no further from my side, thanks!
Any requests for commit cleanup? (Should I leave it be, squash some commits, squash all) |
Resolution of Doxygen Warnings, Mostly wrong/missing/extra params, section renaming and latex/doxygen commands. Things that may require additional attention are flagged with comments.