Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to integrate
linear_svm()
into my company's software, I found two bugs; one simple, one rather subtle:no_intercept
is backwards---you have to specifyno_intercept
to get an intercept. This PR corrects the behavior. :)Classify()
. Specifically, we were usingdata.n_rows - 1
to get the index of the intercept inparameters
---but if there is an intercept, thendata
has one fewer row thanparameters
! So we should useparameters.n_rows - 1
instead.