-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling all the bindings by default. #2773
Comments
This is a nice issue for someone who has a little bit of knowledge with CMake and is looking to contribute. 👍 I'd suggest the first of the two approaches (I think it would be easier), but either works. |
I would like to go ahead with this. Through this issue, I can probably add one more skill to my bag. :) |
@RishabhGarg108 You can toggle the following Line 64 in 4d01fe5
|
Thanks @jeffin143 ! |
Addressed in #2782. |
As discussed yesterday in the IRC, some of the bindings are by default being built with cmake and it is cumbersome to manually switch them off since for most cases, people don't need them. So it might be a good idea to disable all of them by default.
For this, there are to approaches :-
-DBUILD_BINDINGS=OFF
. This option could be given precedence over all otherBUILD_X_BINDINGS
and it will enable/disable all of the bindings at once. (This option could be useful if lets say we add or change anyxx_main.cpp
file and we want to test if all bindings are correctly working or not.)I think both the approaches are fine, and we can do whatever fits best for most.
The text was updated successfully, but these errors were encountered: