Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling all the bindings by default. #2773

Closed
RishabhGarg108 opened this issue Dec 17, 2020 · 5 comments
Closed

Disabling all the bindings by default. #2773

RishabhGarg108 opened this issue Dec 17, 2020 · 5 comments

Comments

@RishabhGarg108
Copy link
Member

As discussed yesterday in the IRC, some of the bindings are by default being built with cmake and it is cumbersome to manually switch them off since for most cases, people don't need them. So it might be a good idea to disable all of them by default.
For this, there are to approaches :-

  1. To disable all the bindings by default. (suggested by @rcurtin and definitely a valid approach)
  2. To add another option -DBUILD_BINDINGS=OFF. This option could be given precedence over all other BUILD_X_BINDINGS and it will enable/disable all of the bindings at once. (This option could be useful if lets say we add or change any xx_main.cpp file and we want to test if all bindings are correctly working or not.)

I think both the approaches are fine, and we can do whatever fits best for most.

@rcurtin
Copy link
Member

rcurtin commented Dec 17, 2020

This is a nice issue for someone who has a little bit of knowledge with CMake and is looking to contribute. 👍 I'd suggest the first of the two approaches (I think it would be easier), but either works.

@RishabhGarg108
Copy link
Member Author

RishabhGarg108 commented Dec 18, 2020

I would like to go ahead with this. Through this issue, I can probably add one more skill to my bag. :)
I would go with the first approach.
Can you suggest me where shall I start looking ?
Thanks!

@jeffin143
Copy link
Member

@RishabhGarg108 You can toggle the following

option(BUILD_GO_BINDINGS "Build Go bindings." ON)
, It is currently ON by default you can switch it off and same with others

@RishabhGarg108
Copy link
Member Author

Thanks @jeffin143 !

@Yashwants19
Copy link
Member

Addressed in #2782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants