Disabling bindings by default in cmake. #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yashwants19
approved these changes
Dec 25, 2020
|
@Yashwants19 , I have updated |
|
Thanks for review @shrit :-D |
|
I am wondering why one test is now failing. Previously it was not failing. |
Some tests are non deterministic, so it's possible that they can fail some time e.g. if the threshold is to tight. |
zoq
reviewed
Dec 25, 2020
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
Okay 👍 I have fixed the style. Thanks for review :) |
|
Thanks @RishabhGarg108 for looking into the issue. 👍 |
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #2773 .
The default options for all bindings are set to "OFF" in this.