Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download old boost version if the compiler is tooo.. old #2940

Merged
merged 1 commit into from May 19, 2021
Merged

Download old boost version if the compiler is tooo.. old #2940

merged 1 commit into from May 19, 2021

Conversation

shrit
Copy link
Member

@shrit shrit commented May 8, 2021

This pull request fixes #2939

Signed-off-by: Omar Shrit omar@shrit.me

@shrit
Download old boost version if the compiler is tooo.. old
145c259 
This pull request fixes mlpack#2939

Signed-off-by: Omar Shrit <omar@shrit.me>
@shrit
Copy link
Member Author

shrit commented May 8, 2021

@rcurtin, I am happy to host it on mlpack website and change the link in order to avoid lost link issues. Let me know what do you think

@birm
Copy link
Member

birm commented May 14, 2021

Unfortunately, boost doesn't seem too consistent about its compiler compatibility notes. Looks like 1.62 works with gcc >= 4.5 (https://www.boost.org/doc/libs/1_62_0/libs/log/doc/html/log/installation.html)

I'll take some time to test on a centos 7 vm.

@birm birm self-requested a review May 14, 2021 15:17
@birm birm mentioned this pull request May 14, 2021
Closed
@rcurtin
Copy link
Member

rcurtin commented May 18, 2021

@rcurtin, I am happy to host it on mlpack website and change the link in order to avoid lost link issues. Let me know what do you think

If it works reasonably well as-is, I'm fine sticking with the external link. After all, we are hoping to remove it soon anyway. :)

rcurtin
rcurtin approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least, even if there are other issues with older compilers in #2939, this should work. 👍

@shrit
Copy link
Member Author

shrit commented May 18, 2021

@rcurtin Yeah, totally agreed, in the meanwhile, I hope at least their website links keep working.

birm
birm approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@birm birm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what environment this now fixes, but it worka as described

@rcurtin rcurtin merged commit ce64315 into mlpack:master May 19, 2021
This was referenced Oct 14, 2022
Closed
Closed
@rcurtin rcurtin mentioned this pull request Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcurtin rcurtin rcurtin approved these changes

@birm birm birm approved these changes

Assignees
No one assigned
Labels
c: build system s: unanswered
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mlpack no longer compiles on RHEL 7 / CentOS 7
3 participants
@shrit @birm @rcurtin