Add accuracy and mean squared error #1016
Conversation
| const DataType& data, | ||
| arma::mat& responses) | ||
| { | ||
| // In the case of neural networks data should be passed without const |
There was a problem hiding this comment.
Fixed in 400abaa, so I think we can remove the extra function here.
Simplify the MSE implementation after merging with the master branch.
| # Define the files we need to compile | ||
| # Anything not in this list will not be compiled into mlpack. | ||
| set(SOURCES | ||
| ) |
There was a problem hiding this comment.
Either we should add the metrics/* files here, or an add_subdirectory(metrics) call somewhere in this file so that the new files are properly added to MLPACK_SOURCES. Let me know if I can clarify anything about that.
There was a problem hiding this comment.
I don't have too much experience with cmake, and I was looking at src/mlpack/core/data/CMakeLists.txt as an example while writing src/mlpack/core/cv/CMakeLists.txt, since src/mlpack/core/data also has some directories. Probably we should fix src/mlpack/core/data/CMakeLists.txt too. I will fix src/mlpack/core/cv/CMakeLists.txt shortly.
There was a problem hiding this comment.
Ah, nice catch, I will commit changes for data/ shortly.
Add the metrics accuracy and mean squared error for cross-validation.