New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy and mean squared error #1016

Merged
merged 5 commits into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@micyril
Member

micyril commented Jun 2, 2017

Add the metrics accuracy and mean squared error for cross-validation.

micyril added some commits Jun 5, 2017

Simplify the MSE implementation
Simplify the MSE implementation after merging with the master branch.
@rcurtin

Looks good to me. If you can handle the CMake comment I'll go ahead and merge.

# Define the files we need to compile
# Anything not in this list will not be compiled into mlpack.
set(SOURCES
)

This comment has been minimized.

@rcurtin

rcurtin Jun 5, 2017

Member

Either we should add the metrics/* files here, or an add_subdirectory(metrics) call somewhere in this file so that the new files are properly added to MLPACK_SOURCES. Let me know if I can clarify anything about that.

@rcurtin

rcurtin Jun 5, 2017

Member

Either we should add the metrics/* files here, or an add_subdirectory(metrics) call somewhere in this file so that the new files are properly added to MLPACK_SOURCES. Let me know if I can clarify anything about that.

This comment has been minimized.

@micyril

micyril Jun 5, 2017

Member

I don't have too much experience with cmake, and I was looking at src/mlpack/core/data/CMakeLists.txt as an example while writing src/mlpack/core/cv/CMakeLists.txt, since src/mlpack/core/data also has some directories. Probably we should fix src/mlpack/core/data/CMakeLists.txt too. I will fix src/mlpack/core/cv/CMakeLists.txt shortly.

@micyril

micyril Jun 5, 2017

Member

I don't have too much experience with cmake, and I was looking at src/mlpack/core/data/CMakeLists.txt as an example while writing src/mlpack/core/cv/CMakeLists.txt, since src/mlpack/core/data also has some directories. Probably we should fix src/mlpack/core/data/CMakeLists.txt too. I will fix src/mlpack/core/cv/CMakeLists.txt shortly.

This comment has been minimized.

@rcurtin

rcurtin Jun 5, 2017

Member

Ah, nice catch, I will commit changes for data/ shortly.

@rcurtin

rcurtin Jun 5, 2017

Member

Ah, nice catch, I will commit changes for data/ shortly.

@rcurtin rcurtin merged commit d9b4b59 into mlpack:master Jun 5, 2017

3 checks passed

Style Checks Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@micyril micyril deleted the micyril:metrics branch Jun 6, 2017

@micyril micyril changed the title from Metrics to Add accuracy and mean squared error Aug 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment