Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have AppVeyor run the tests too #1188

Merged
merged 20 commits into from Feb 7, 2018
Merged

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented Jan 2, 2018

Let's see what this does...

@zoq
Copy link
Member

zoq commented Jan 5, 2018

Should be save to use set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj") in release mode as well.

@zoq
Copy link
Member

zoq commented Feb 7, 2018

Perhaps, you can't enable the test upload inside a PR, so we would have to merge this first. I think this is ready once, all the test commands are removed.

@rcurtin
Copy link
Member Author

rcurtin commented Feb 7, 2018

Sure, we can merge this now if you like and see if the tests magically start working. At the very least, running the tests at all is an improvement. I can open an issue after this is merged about getting the test output to upload correctly.

@zoq
Copy link
Member

zoq commented Feb 7, 2018

Sounds good.

@rcurtin
Copy link
Member Author

rcurtin commented Feb 7, 2018

@mlpack-jenkins test this please

@rcurtin rcurtin merged commit eae2453 into mlpack:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants