removed some warning messages #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcurtin
approved these changes
Jan 30, 2018
There was a problem hiding this comment.
Nice, thank you for the fixes (including the spelling fix). Always great to resolve stuff like this. I'll go ahead and merge this in 3 days in case anyone has any other comments, and also just wait to see if the build is successful (I see no reason why it wouldn't be though).
zoq
approved these changes
Jan 30, 2018
|
Thanks again for the nice contribution. If you like, I can add your name to the list of contributors in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building mlpack I encountered some warning messages corresponding to "uninitialised variables and unused variables". Hence I tried to remove them.